Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Select one field list logic error even if no follow-up question is specified #186

Closed
lognaturel opened this issue Sep 7, 2017 · 4 comments
Labels

Comments

@lognaturel
Copy link
Member

Create a group. Place a select one in the group. Toggle the "display on one screen" checkbox on the group.

@lognaturel lognaturel added the bug label Sep 7, 2017
@florianm
Copy link
Contributor

@lognaturel I'm getting the same error, however upload to ODK-A still works, and ODK Validate also finds no problem. ODK Build shows the select one field in red with the following warning:

[ ] Follow-up Question
Ask if the response is:
(inactive, but a value is selected)
    Because this control is within a single-screen group (field list), any expressions that reference other fields in the same group will not work.

@florianm
Copy link
Contributor

florianm commented Oct 31, 2017

Found a fix: dragging the falsely red-flagged "select one" to another position within the group will turn off the warning. Dragging it back to the original position will preserve the "ok" status.

The warning itself is legit - follow-up fields will not work inside a "keep on one screen" group as both the select one and the follow up fields render together (makes sense to me).

@issa-tseng
Copy link
Member

Okay, the issue here is that it genuinely is supposed to be a warning and not an error, but right now there's no visual distinction between the two.

@issa-tseng issa-tseng self-assigned this Jan 23, 2018
issa-tseng added a commit that referenced this issue Jan 23, 2018
* fixed by accepting boolean false as a prerequisite fail for the actual
  check; so false, null, and "" do not trigger validation for the field.
* the rule is also marked as "severity: warning" which doesn't appear to
  actually do anything. perhaps it should someday.
* for now, resolves #186.
@florianm
Copy link
Contributor

Currently, the warning around "follow up question" and the widget colour disappear only after the widget has been dragged around. It would be great if it would disappear when the "follow up question" checkbox is unchecked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants