Groups with corresponding instance node should have ref attribute linking the two

[lognaturel]

If a group has a corresponding node in the instance, it should have a ref attribute: https://opendatakit.github.io/xforms-spec/#groups

Build doesn't add one which can cause problems in cases like nested groups: getodk/javarosa#218 (comment)

[issa-tseng]

Okay, I'd like to fix this but I don't fully understand the implications here. Build exclusively uses nodeset bindings, it never uses ref currently. So if groups suddenly get a ref notation, does that impact the present explicit absolute nodeset bindings?

And, which groups should get refs? All? Only the implicit ones that wrap repeats?

[lognaturel]

In ODK XForms bind and nodeset are used interchangeably as far as I can tell. In the specific case of groups I'm 100% sure that is the case -- you could use either.

I think that in Build all groups have a corresponding node in the instance, right? There's no way to specify a group and only have it in the body? If that's indeed the case then all groups generated by Build should be linked to the node they correspond to in the instance. ref would be consistent with pyxform but nodeset will have the same effect.

[issa-tseng]

Okay—I'll add this in a branch and we can test the resulting forms in Collect to double check this. I'm still fairly convinced this change will somehow break everything.

[issa-tseng]

You are annoying sometimes, @opendatakit-bot. :)

[getodk-bot]

Hello @issa-tseng, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[yanokwa]

@issa-tseng We've merged getodk/collect#2764 in Collect and Build users will not be able to benefit from it until this issue is resolved.

[issa-tseng]

fixed in #213