Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Update docker-compose.yml to use a specific release #300

Closed
yanokwa opened this issue Mar 22, 2022 · 3 comments · Fixed by #301
Closed

Update docker-compose.yml to use a specific release #300

yanokwa opened this issue Mar 22, 2022 · 3 comments · Fixed by #301

Comments

@yanokwa
Copy link
Member

yanokwa commented Mar 22, 2022

Consider pinning docker-compose.yml to a specific release and pinning docker-compose.dev.yml to master so pre-releases are dogfooded.

@yanokwa yanokwa changed the title Update docker-compose.yml to use Update docker-compose.yml to use a specific release Mar 22, 2022
@florianm
Copy link
Contributor

Would you be happy to leave docker-compose.dev.yml at :latest which should be the latest master?

Side thought, how about a release issue template with a step by step release process?

@yanokwa
Copy link
Member Author

yanokwa commented Mar 23, 2022

I believe "latest" is the latest release and "master" is master. Sounds like we both want master, correct?

@florianm
Copy link
Contributor

"latest" is the latest build without an explicit docker tag or with the tag "latest". Since the ghcr.yml GH action pushes only the tag "master" and not "latest" (see https://github.com/getodk/build/pkgs/container/build/versions), you are right that docker-compose.dev.yml should tag "master" and docker-compose.yml should tag the latest tagged release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants