This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
Build image on every push, hide secrets, more consistent naming #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanokwa
changed the title
florianm
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Happy with the PR, good to merge.
Good to have a definite opinion on naming and the "odk" prefix!
Another reminder here to change the docker-compose file from ":latest" to pinned versions to avoid accidental breakage.
Happy for my PAT to be removed as repo secret and for the odkbuild package to be deleted.
Could the new packages ("build" and "build2xlsform") be made public again?
|
I've removed the PAT on both repos and made sure packages are public. I've filed an issue at #300 to discuss the pinning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read getodk/build2xlsform#37 first.
An additional change to this PR is prepending "odk" to "build2xlsform" so we have a consistent naming scheme.
If you are happy with this, I can...