Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

#95 Use short git hash for identifying version in About menu #225

Merged
merged 1 commit into from
Apr 10, 2019
Merged

#95 Use short git hash for identifying version in About menu #225

merged 1 commit into from
Apr 10, 2019

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Apr 10, 2019

No description provided.

@issa-tseng issa-tseng self-requested a review April 10, 2019 18:37
issa-tseng
issa-tseng approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@issa-tseng issa-tseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally the intent had been for the SHA to get cut down only for final display in the about menu, but at this point this ticket has run for so long and the SHA isn't actually used anywhere else in the application, so we'll just roll with this. thank you!

@issa-tseng issa-tseng merged commit 5fee2f2 into getodk:master Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issa-tseng issa-tseng issa-tseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moogacs @issa-tseng