This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
Fix #268: create empty nodes for missing translations #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i have not tested or verified this, but the changes look simple enough. |
florianm
commented
Jan 14, 2022
| var pushChildren = function (arr, ext, frm, txn, pre) { | ||
| var pre = (pre !== undefined) ? pre : ""; | ||
|
|
||
| // #268: skip unless ext contains at least one non-empty value |
There was a problem hiding this comment.
We test whether e.g. English (first lang) has a value given, while other added languages are empty. In that case, we'll want empty nodes. Only if nothing is given, we can skip creating nodes.
florianm
commented
Jan 14, 2022
| _noWhitespace: true, | ||
| children: getTranslation(ext, txn, prefix = pre) | ||
| }); | ||
| } else if ((ext !== undefined) && contains_non_empty_value && _.isEmpty(ext[txn._languageCode])) { |
There was a problem hiding this comment.
If any other language contains a non empty value (contains_non_empty_value) but this translation is empty (isEmpty...), then push an empty node (children: [""]).
florianm
commented
Jan 14, 2022
| @@ -262,7 +293,7 @@ var dataNS = odkmaker.namespace.load('odkmaker.data'); | |||
| { | |||
|
|
|||
| // The translation for the main control object obj | |||
| var schoolyard = [{ | |||
| var tx = [{ | |||
There was a problem hiding this comment.
I've renamed this variable because the metaphor of pushing children across a schoolyard has no explanatory value. The additional function docs now clarify what this function does.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug that was introduced through added support for extras (short label, guidance hint, image labels etc).
This patch has been split out from #266 as requested.