Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

improve: add favicon #280

Merged
merged 1 commit into from
Jan 28, 2022
Merged

improve: add favicon #280

merged 1 commit into from
Jan 28, 2022

Conversation

florianm
Copy link
Contributor

@florianm florianm commented Jan 28, 2022 •
edited

  • Add a copy of ODK Central's favicon into the public/images folder
  • Link favicon from index.erb
  • Closes Favicon #279
  • Resolves browser console warning about missing favicon
  • Browser title now looks like this
    image
  • Creates a unified user experience across ODK products

@florianm florianm self-assigned this Jan 28, 2022
@florianm florianm added this to In progress in Roadmap via automation Jan 28, 2022
@florianm florianm added this to the 0.4.1 hotfixes milestone Jan 28, 2022
yanokwa
yanokwa approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@yanokwa yanokwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a screenshot.

Roadmap automation moved this from In progress to Reviewer approved Jan 28, 2022
@florianm florianm merged commit 440517d into getodk:master Jan 28, 2022
Roadmap automation moved this from Reviewer approved to Done Jan 28, 2022
@florianm florianm deleted the 279-favicon branch January 28, 2022 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yanokwa yanokwa yanokwa approved these changes

@lognaturel lognaturel Awaiting requested review from lognaturel

Assignees

@florianm florianm

Labels
user experience
Projects
Roadmap
Done
Milestone
0.4.1 hotfixes
Development

Successfully merging this pull request may close these issues.

Favicon
2 participants
@florianm @yanokwa