Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: resolve prefer-promise-reject-errors violations #1040

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Nov 8, 2023

No description provided.

@alxndrsn alxndrsn changed the title eslint: tests: resolve prefer-promise-reject-errors violations eslint: resolve prefer-promise-reject-errors violations Nov 8, 2023
Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement! It's also clearer now which tests just need some error (any error) and which need the error to look a particular way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is probably for #1071, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 yes, thanks for catching that!

@alxndrsn alxndrsn merged commit c1cd73f into getodk:master Feb 12, 2024
1 check passed
@alxndrsn alxndrsn deleted the promise-reject-errors branch February 12, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants