remove dev dependency: node-fetch #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 6, 2024 21:21
fetch() global has been available since node v18. It is still officially "experimental" until node v21, but it seems reasonable to use it in development before then. See: https://nodejs.org/api/globals.html#fetch
alxndrsn
changed the title
ktuite
approved these changes
May 7, 2024
matthew-white
pushed a commit
that referenced
this pull request
May 8, 2024
fetch() global has been available since node v18. It is still officially "experimental" until node v21, but it seems reasonable to use it in development before then. See: https://nodejs.org/api/globals.html#fetch This avoids node-fetch/node-fetch#1735, which I've seen locally when working with e2e tests. However, it does seem like global fetch can exhibit a similar but much less frequent issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch()global has been available since node v18. It is still officially "experimental" until node v21, but it seems reasonable to use it in development before then.See: https://nodejs.org/api/globals.html#fetch
This avoids node-fetch/node-fetch#1735, which I've seen locally when working with e2e tests. However, it does seem like global
fetchcan exhibit a similar but much less frequent issue.