Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change entities deletedAt precision and add timezone #1145

Merged
merged 1 commit into from
May 17, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented May 15, 2024

Closes #1104

Makes deletedAt field on entities table have consistent timestamp type.

In this issue, we chose to use timestamptz(3) for timestamps, but that was missed when creating this column in this table and it was just set to timestamp.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white May 15, 2024 19:59
@ktuite ktuite merged commit 9b9f6f6 into master May 17, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/entity-deleted-tz branch May 17, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entities."deletedAt" has different type from other timestamp columns
2 participants