Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dataset verbs in endpoints about forms #1146

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented May 17, 2024

Closes getodk/central#612

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Base automatically changed from ktuite/refactor_form_flow to master May 18, 2024 00:08
@ktuite ktuite force-pushed the ktuite/dataset_verbs branch 2 times, most recently from 02a95ef to 225da1b Compare May 20, 2024 21:56
@ktuite ktuite linked an issue May 20, 2024 that may be closed by this pull request
@ktuite ktuite marked this pull request as ready for review June 3, 2024 22:55
@ktuite ktuite requested a review from matthew-white June 3, 2024 22:55
lib/model/query/datasets.js Outdated Show resolved Hide resolved
@ktuite ktuite merged commit 3d868e1 into master Jun 11, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/dataset_verbs branch June 11, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check dataset verbs in form endpoints
2 participants