Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify mediaFile type=entityList for datasets in form manifest #1147

Merged
merged 1 commit into from
May 23, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented May 21, 2024

Part of getodk/central#665 and larger issue getodk/central#668

Adds type=”entityList” to manifest for attachments that are actually datasets/entity lists. (integrityUrl coming next.)

<mediaFile type=”entityList”>
  <filename>people.csv</filename>
  <hash>md5:9fd39ac868eccdc0c134b3b7a6a25eb7</hash>
  <downloadUrl>http://other.appspot.com/blobSource?foo=222</downloadUrl>
  <integrityUrl>http://blah</integrityUrl>
 </mediaFile>

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white May 21, 2024 14:42
@ktuite ktuite merged commit e1c74de into master May 23, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/entityList_manifest branch May 23, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants