refactor #331
Merged
refactor #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we used to define the most recently submitted submission_def as the current one. i preferred this bc i don't want to duplicate information that can get out of sync. * but it's really slow to do that query, and we have to do it all over. * so just use a flag instead. * there isn't yet a way to make a new version of an existing submission to begin with, so all submissions are current and all we have to do is always flag true. * but the migration does the full query anyway just in case.
* but this isn't accessible yet. first we have to decide how to query and return def information along w the logical submission.
* but actually basic submission streaming does work now. * but it will require a patch to slonik. :(
* it won't hurt anything i promise.
* don't capture ten million stack traces.
* now it's in form-attachments. * it's been a problem, the little structural inconsistencies, in trying to trace and locate code.
* the rest is to come.
issa-tseng
commented
Feb 12, 2021
|
this will be ready to merge as soon as slonik is merged upstream and updated here. |
This was referenced Feb 23, 2021
This was referenced Mar 4, 2021
matthew-white
added a commit
to getodk/central
that referenced
this pull request
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.