Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard form buttons wrap in French #370

Closed
matthew-white opened this issue Aug 24, 2020 · 1 comment · Fixed by #379
Closed

Standard form buttons wrap in French #370

matthew-white opened this issue Aug 24, 2020 · 1 comment · Fixed by #379
Labels
bug i18n Internationalization

Comments

@matthew-white
Copy link
Member

The "standard form buttons" include the Preview button and the Download button. In English, they are shown on a single line. However, in French (and possibly other locales), they can wrap onto a second line, because the text of the buttons is longer.

On the form overview page:

overview_fr

On the draft status page:

status_fr

Given the length of the button text, it might be hard to keep the buttons on a single line along with the version string. I think it might work best to move the buttons below the version string. For example:

On the form overview page:

Screen Shot 2020-08-20 at 5 59 29 AM

On the draft status page:

Screen Shot 2020-08-20 at 5 57 40 AM

On the draft status page, we could also consider moving the "Upload new definition" button down to the Actions section, joining the "Publish Draft" and "Abandon Draft" buttons.

@matthew-white matthew-white added bug needs discussion Discussion needed before work can begin i18n Internationalization labels Aug 24, 2020
@issa-tseng
Copy link
Member

the screenshots seem fine to me for now

@matthew-white matthew-white removed the needs discussion Discussion needed before work can begin label Sep 24, 2020
matthew-white added a commit that referenced this issue Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n Internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants