Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if user selects 100+ columns #396

Closed
matthew-white opened this issue Dec 16, 2020 · 2 comments · Fixed by #645
Closed

Show warning if user selects 100+ columns #396

matthew-white opened this issue Dec 16, 2020 · 2 comments · Fixed by #645

Comments

@matthew-white
Copy link
Member

Above the submissions table, we show a dropdown that allows the user to select the columns to display in the table. We only allow the user to select 100 columns at a time, because anything above that takes some time to render. For example, on my computer it takes about 3 seconds to render 100 columns for 250 submissions.

However, instead of disabling additional selection after 100 columns, it would be better to simply warn the user about the potential slowdown. That way, the user can select additional columns if they want to while knowing what to expect. Removing the logic in the SubmissionFieldDropdown component around disabling should also simplify that component.

If the user selects 100+ columns, they should see a warning beneath the list of fields. The warning should show an .icon-exclamation-triangle as we do elsewhere, alongside the text "Selecting too many columns might slow down your computer."

@elmarek
Copy link

elmarek commented Dec 16, 2020

Hi Matthew, I'm going to give this issue a go. Hopefully submit a pull request soon. Thanks!

@matthew-white
Copy link
Member Author

Thanks, @elmarek! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants