-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set maximum width for frontend #447
Labels
behavior verified
Behavior has been manually verified
enhancement
New feature or behavior
styles
Changes to CSS
Comments
matthew-white
changed the title
Set maximum width on container
Set maximum width for frontend
May 30, 2022
matthew-white
added
needs testing
Needs manual testing
needs design review
Needs verification from designer
labels
Mar 25, 2023
matthew-white
added a commit
that referenced
this issue
Mar 27, 2023
2 tasks
2 tasks
matthew-white
added a commit
that referenced
this issue
May 25, 2023
Closes #447. Also moving the variables for Bootstrap breakpoints to the main section of _variables.scss.
Tested with Success! |
srujner
added
behavior verified
Behavior has been manually verified
and removed
needs testing
Needs manual testing
labels
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
behavior verified
Behavior has been manually verified
enhancement
New feature or behavior
styles
Changes to CSS
Right now, Frontend will use the full width of the page. However, after a certain width, that detracts from the user experience. Instead, we want to set a maximum width for Frontend to use. (Let's try 1400px.) The content should be centered on the page.
One caveat has to do with the Submissions and Testing pages. On those pages, we want the submissions table to use nearly the full width of the page. We could set it up so that even while the rest of the page has a max width of 1400px, the table somehow breaks out of the container and uses more width. Or we could set it up so that on the Submissions and Testing pages, Frontend as a whole uses the full width of the page.
Right now we use the Bootstrap full-width container (
.container-fluid
). However, we could use the Bootstrap responsive fixed-width container instead (.container
). Or we could update.container-fluid
or write our own container.One thing that we know will be an issue is elements with
position: fixed;
. However, those are not common in Frontend. The main example I can think of isFormAttachmentPopups
.Notes for the QA team
See #775 for information about the expected behavior.
The text was updated successfully, but these errors were encountered: