Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio is hearable after removing response on Audio widget #4005

Closed
mmarciniak90 opened this issue Aug 3, 2020 · 3 comments · Fixed by #4006
Closed

Audio is hearable after removing response on Audio widget #4005

mmarciniak90 opened this issue Aug 3, 2020 · 3 comments · Fixed by #4006

Comments

@mmarciniak90
Copy link
Contributor

mmarciniak90 commented Aug 3, 2020 •
edited

Software and hardware versions

Collect v1.27.3 (older versions were not verified)

Steps to reproduce the problem

  1. User adds audio to Audio widget
  2. User plays it
  3. User removes response when audio is played
  4. The response is removed but the sound is still hearable

Expected behavior

  • Audio is not hearable after removing response

Other information

Noticed while testing #3992
@seadowg
Copy link
Member

seadowg commented Aug 3, 2020

@mmarciniak90 are these both visible in Collect 1.27.3?

@mmarciniak90
Copy link
Contributor Author

@seadowg I retested it on v1.27.3 and only the case with removing response is reproducible.

@seadowg
Copy link
Member

seadowg commented Aug 4, 2020

@seadowg yeah getting the same thing 👍. Could we split this in two issues and mark the second ("Use case 2") as a "regression"?

@mmarciniak90 mmarciniak90 changed the title Incorrect behavior on the audio widget Audio is hearable after removing response on Audio widget Aug 4, 2020
@SaumiaSinghal SaumiaSinghal mentioned this issue Aug 4, 2020
Merged
3 tasks
SaumiaSinghal added a commit to SaumiaSinghal/collect that referenced this issue Aug 4, 2020
@SaumiaSinghal
fix getodk#4005
57ed5ab
SaumiaSinghal added a commit to SaumiaSinghal/collect that referenced this issue Aug 19, 2020
@SaumiaSinghal
fix getodk#4005
ffce538
SaumiaSinghal added a commit to SaumiaSinghal/collect that referenced this issue Aug 25, 2020
@SaumiaSinghal
fix getodk#4005
f2ce6ea
SaumiaSinghal added a commit to SaumiaSinghal/collect that referenced this issue Aug 27, 2020
@SaumiaSinghal
fix getodk#4005
70f46e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reworking Audio widget SaumiaSinghal/collect
2 participants
@seadowg @mmarciniak90