Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent updates to entities that don't appear in entity list #6031

Open
2 tasks
Tracked by #5991
seadowg opened this issue Mar 22, 2024 · 1 comment
Open
2 tasks
Tracked by #5991

Prevent updates to entities that don't appear in entity list #6031

seadowg opened this issue Mar 22, 2024 · 1 comment
Labels
Milestone

Comments

@seadowg
Copy link
Member

seadowg commented Mar 22, 2024

Blocked by #5972
Blocked by #6029

An entity not in local entity list can currently be updated. In this case, the local entity list should not be changed.

Acceptance

  • Given that I have an entity update form with a fixed id and baseVersion
    And the entity does not appear in the device's entity list
    When I fill and finalize the form
    Then a new entity is not available to other follow up forms
    And a new entity does not appear in the "View local entities"

  • Given that I have an entity update form with a fixed id and baseVersion
    And the entity does appear in the device's entity list
    When I fill and finalize the form
    Then the updated entity is available to other follow up forms

@seadowg seadowg mentioned this issue Mar 22, 2024
12 tasks
@seadowg seadowg changed the title An entity not in local entity list can be updated. In this case, the local entity list should not be changed Prevent updates to entities that don't appear in entity list Mar 22, 2024
@lognaturel
Copy link
Member

Then a new entity is available to other follow up forms

You mean the updated values for the existing entity, I think?

I'm really, really tempted to add logging to the acceptance criteria here! It feels like this kind of weird case would be helpful to have a record of, even just for our own sanity.

@seadowg seadowg added this to the v2024.2 milestone Mar 25, 2024
@seadowg seadowg removed the blocked label Apr 3, 2024
@seadowg seadowg self-assigned this Apr 3, 2024
@seadowg seadowg added the blocked label Apr 3, 2024
@seadowg seadowg removed their assignment Apr 3, 2024
@seadowg seadowg modified the milestones: v2024.2, v2024.3 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: not ready
Development

No branches or pull requests

2 participants