Expose action with entity #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
approved these changes
Apr 4, 2024
lognaturel
reviewed
Apr 4, 2024
lognaturel
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for getodk/collect#6031
This will allow a client to determine that an exposed entity is an update and handle edge cases around that (like the one described in the attached issue).
What has been done to verify that this works as intended?
Updated tests.
Why is this the best possible solution? Were any other approaches considered?
This is quite a simple change. I considered also removing the versioning logic from JavaRosa now that clients will have access to the action and theoretically could handle it for themselves. However, I wanted to keep the entity exposed as simple to deal with as possible - an
UPDATEis communicating "update the entity with this id to this version with this label and properties".How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Shouldn't change anything on client side as the change is purely additive.