New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jacoco to latest release v0.8.0 #1993
Conversation
Heya @shobhitagarwal1612! The reason for the downgrade was to be able to work with Firebase. Do you have any new information that suggests they've upgraded? |
@lognaturel I have updated the description for the PR |
@lognaturel Should I remove the |
Seems Firebase continues to generate Great idea to reach out to the firebase community. Do you want to link that post here for future reference?
Good idea. |
I used the slack channel. Can that be linked? |
Slack thread conversation https://firebase-community.slack.com/archives/C1MTSQ5QT/p1520591905000220 |
ed72ede
to
9dcbc7b
Compare
It works !!! Check out this link |
@lognaturel I've cleaned the commits and removed unncessary changes |
Well isn't that great! Thanks, @shobhitagarwal1612!! Mysterious that 0.7.9 didn't work... but oh well! |
In case if you are wondering the source of the solution, it is adopted from here |
Some of the unit tests were not getting included in the code coverage report due to some bug in the old jacoco version that we were using. The latest version v0.8.0 is supposed to fix all that issue.
For eg.
Validator.java
is 100% covered but in codecov it displays 0%.What has been done to verify that this works as intended?
Tried running the report locally for unit tests and the code coverage increased as expected (
Validator
file showing 100% coverage and many others)Why is this the best possible solution? Were any other approaches considered?
Tried approaching the
firebase-community
and they suggest this as one of the possible solutionsAre there any risks to merging this code? If so, what are they?
Before merging, we need to ensure that the file generated by
firebase is also of the same version so that the report can be properly generated.
Do we need any specific form for testing your changes? If so, please attach one.
no