Fixed save icon color #2194
Closed
Fixed save icon color #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-2193
branch
from
d9bc2fa
to
0ac1fd4
Compare
lognaturel
approved these changes
May 14, 2018
|
Good catch, @grzesiek2010. I think this gets fixed by #2178 so it would be good to get that one verified and merged first. |
ahh, I didn't know. I really don't like it since that pr was supposed just to add a description and the title says the same but it contains a bunch of other fixes. So it may be always confusing for our QAs who don't analyze the code. But since you have accepted it I'm not going to complain. |
|
Thanks, @grzesiek2010! I think we're good on this one so I will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2193
What has been done to verify that this works as intended?
I tested Import/Export settings in both themes.
Why is this the best possible solution? Were any other approaches considered?
It's the same approach use for other vectors.
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass.