Add pause/unpause to recording #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
commented
Dec 2, 2020
| @@ -65,7 +65,7 @@ internal open class AudioRecorderDependencyModule { | |||
|
|
|||
| @Provides | |||
| open fun providesRecorder(application: Application): Recorder { | |||
| return MediaRecorderRecorder(application.cacheDir) { RealMediaRecorderWrapper(MediaRecorder()) } | |||
| return RecordingResourceRecorder(application.cacheDir) { MediaRecorderRecordingResource(MediaRecorder()) } | |||
There was a problem hiding this comment.
Naming is hard. I'm attempting to make it clear that this could be implemented using something other than MediaRecorder. It's the direction I think we'd need to take if we look at a lossless codec.
lognaturel
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4234
Blocked by #4241The interface isn't the greatest right now (switches between Pause/Resume with same icon) but will iterate on this when we do design polish.
What has been done to verify that this works as intended?
New tests and verified manually.
Why is this the best possible solution? Were any other approaches considered?
Just uses the Android
MediaRecorderto pause so no big changes here. Annoyingly this doesn't work below API 24. Additional comments inline.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Definitely think we should leave QA on this until we have the "finished" (ready for release) feature set.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.