Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak new theme #4843

Merged
merged 3 commits into from Oct 14, 2021
Merged

Tweak new theme #4843

merged 3 commits into from Oct 14, 2021

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 4, 2021

Closes #4832

As well as fixing the problems in the issue this makes the back/next button bar more visible. This should really use a BottomAppBar which would give us the correct color based on elevation but that's a switch we don't need to dive into right now.

What has been done to verify that this works as intended?

Quick play with the app

Why is this the best possible solution? Were any other approaches considered?

The only real discussion here is around the nav bar, and I've covered that above.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should just fix the issues! I think this can go in without QA as it's just some small fixes.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 4, 2021 14:39
@kkrawczyk123
Copy link
Contributor

kkrawczyk123 commented Oct 14, 2021

Tested with success!
Verified on Androids 5.1 and 11.

Tested cases:

  • default/light/dark mode
  • server url
  • username
  • odk password
  • fallback submission url
  • project name
  • project icon
  • hex in project color
  • form metadata/username
  • form metadata/phone number
  • form metadata/email address
  • admin password/show admin password
  • all widgets
  • ex type widgets
  • back and next button
  • get blank form/ get selected button
  • delete saved form

@mmarciniak90
Copy link
Contributor

Tested with success on Android versions: 8.1, 9.0, 10.0

@grzesiek2010 grzesiek2010 merged commit a13a45f into getodk:master Oct 14, 2021
@seadowg seadowg deleted the theme-tweaks branch October 14, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with newly updated themes
4 participants