Fixed crash when using mapbox on Android 11 #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Oct 13, 2021
|
Tested with success! Tested cases:
regression checks on alldevices:
|
|
Tested with success on Android versions: 8.1, 9.0, 10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4851
What has been done to verify that this works as intended?
I wasn't able to reproduce the bug so asked @kkrawczyk123 to take a quick look and the fix seemed to work.
Why is this the best possible solution? Were any other approaches considered?
The bug was reported in mapbox repository mapbox/mapbox-gl-native-android#425
and it's already fixed.
We could just update mapbox in our codebase and it should work but I find it risky since we are about to release a new version of our app and it might introduce other bugs. That's why I decided to go with this solution also described in one of the comments: mapbox/mapbox-gl-native-android#425 (comment)
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the bug. We don't need to verify anything else.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with geo widgets like the
All WidgetsformDoes this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.