Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak button style to have softer text #4853

Merged
merged 1 commit into from Oct 13, 2021
Merged

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 12, 2021

This customizes the buttons in the app to use a lighter weight font and adapts the letter spacing to fit that.

What has been done to verify that this works as intended?

Eyeballed on the emulator.

Why is this the best possible solution? Were any other approaches considered?

Discussed the changes with @lognaturel before implementation and we agreed that getting the button text to look more like it did before would be a good idea at the moment. We'll hopefully revise our use of the giant main menu buttons over the coming releases.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Think we can avoid QA as we'd likely catch any visual weirdness in upcoming regression testing.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 12, 2021 16:31
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@seadowg seadowg merged commit 3fcd7da into getodk:master Oct 13, 2021
@seadowg seadowg deleted the button-style branch October 13, 2021 09:33
@lognaturel lognaturel mentioned this pull request Oct 13, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants