Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused json.org dependency #4997

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Jan 25, 2022

Removes the misleading org.json dependency. It's shadowed by Android's org.json. I discovered this when I tried using org.json in JavaRosa. That worked but when I tried it in Collect there were errors about classes missing. This Stackoverflow post helped me understand what was going on.

What has been done to verify that this works as intended?

Ran Collect and verified that things compile.

Why is this the best possible solution? Were any other approaches considered?

This makes the origin of org.json imports clearer.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There should be no impact. The fact that things compile gives me confidence that all is well. There should be no actual difference as far as I understand.

Importing/exporting settings, settings QR codes and vector offline tile support for Mapbox are potentially affected.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel
Copy link
Member Author

lognaturel commented Jan 25, 2022

Hmm, the modules that CI ran tests for seems wrong? I ran tests locally and that seemed to hit all of them.

@lognaturel
Copy link
Member Author

I was thinking this might not need QA? @seadowg were you thinking a bit of exploratory testing around the areas I mentioned? It's hard to imagine what would be different given that the APIs are identical and all tests pass. Seems it'd have to be a gnarly edge case or something.

@seadowg
Copy link
Member

seadowg commented Feb 7, 2022

@lognaturel agreed. I'd assumed from your comments in "How does this change affect users..." that you'd prefer testing, and I'm always happy to defer to the author on that one. I'll remove the label and you can merge when ready.

@lognaturel lognaturel merged commit 61e3f3c into getodk:master Feb 7, 2022
@lognaturel lognaturel deleted the remove-json.org branch February 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants