Remove unused json.org dependency #4997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the misleading org.json dependency. It's shadowed by Android's org.json. I discovered this when I tried using org.json in JavaRosa. That worked but when I tried it in Collect there were errors about classes missing. This Stackoverflow post helped me understand what was going on.
What has been done to verify that this works as intended?
Ran Collect and verified that things compile.
Why is this the best possible solution? Were any other approaches considered?
This makes the origin of
org.json
imports clearer.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There should be no impact. The fact that things compile gives me confidence that all is well. There should be no actual difference as far as I understand.
Importing/exporting settings, settings QR codes and vector offline tile support for Mapbox are potentially affected.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.