Fixed the RangePicker widget #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-5284
branch
from
726bf5c
to
6afe9e2
Compare
seadowg
requested changes
Dec 13, 2022
collect_app/src/main/java/org/odk/collect/android/fragments/dialogs/NumberPickerDialog.kt
Outdated
Show resolved
Hide resolved
collect_app/src/test/java/org/odk/collect/android/widgets/range/RangePickerDecimalWidgetTest.kt
Outdated
Show resolved
Hide resolved
…st to kotlin and added new tests
grzesiek2010
force-pushed
the
COLLECT-5284
branch
from
6afe9e2
to
454e4d5
Compare
seadowg
reviewed
Dec 15, 2022
collect_app/src/test/java/org/odk/collect/android/widgets/range/RangePickerWidgetUtilsTest.kt
Outdated
Show resolved
Hide resolved
seadowg
approved these changes
Dec 16, 2022
|
Tested with Success! Verified on Androids: 10 Verified cases:
|
|
Tested with Success! Verified on Androids: 5.1 and 13 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5284
What has been done to verify that this works as intended?
I've added automated tests and tested the fix manually.
Why is this the best possible solution? Were any other approaches considered?
As we agreed in the issue to avoid the bug in
NumberPickerwe should display all elements in the ascending order. It is the easiest solution.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please test range widgets (integer and decimal) with
pickerappearance. There is a lot of refactoring that might spoil something. Other widgets are safe.Do we need any specific form for testing your changes? If so, please attach one.
This for example: rangePickerWidget.xlsx
but be creative.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.