-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when typing in instance name #5506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Tests and code look good and I ran it.
If we end up using this component more we can iterate on the look and feel but given how few people will see this I think it's good enough. I probably would have gone with the blue background. I also do prefer the inline link over the button (but again, not important).
Tested with Success! Verified on Android 10 Verified Cases:
|
Tested with Success! Verified on Android 13 |
Closes #5489
A warning will appear when adding/editing an instance name (in the "Save as" field) at the end of a form.
What has been done to verify that this works as intended?
New tests and verified manually.
Why is this the best possible solution? Were any other approaches considered?
A few choices to discuss here:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just adds the warning, so not a lot of risk here. This can probably merge without QA provided the reviewers have a quick play with it.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.