Use kotlin extension function to delete directories instead of commonsIO #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-5558
branch
from
ada7368
to
fc774a3
Compare
Yes, it happens on my Moto G5, Android 7.0. I had not experienced it before this beta. I'll check this PR on the same device tomorrow! |
seadowg
approved these changes
May 2, 2023
|
@lognaturel I think you can go ahead and merge this if it fixes your crash |
|
Thank you! I was also getting a crash when deleting submissions so it makes a lot of sense that it was related to the delete part of match exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5558
What has been done to verify that this works as intended?
I wasn't able to reproduce the issue but I've tested if removing directories work well with the new code.
Why is this the best possible solution? Were any other approaches considered?
I used the kotlin extension function for removing directories as it should be safe and work without any problems.
@lognaturel were you able to reproduce the issue? It's interesting that it happens only on the newest beta but we didn't update commons-io. It's still v2.5 and on stackoverflow people claim the problem occurs when they use newer versions.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
If we can reproduce the issue then let's test the scenario described in the issue otherwise it doesn't make much sense. We can only test resisting the app/ removing form to make sure directories are removed properly.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.