Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list view heights for delete lists #5597

Merged
merged 4 commits into from
May 19, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented May 18, 2023

Closes #5594

What has been done to verify that this works as intended?

Verified manually.

Why is this the best possible solution? Were any other approaches considered?

No other option here - the height for the list views was incorrectly set to fill the whole screen (rather than the available space).

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

As I pointed out in the issue, this ended up being pretty hard to reproduce as you need the exact right number of forms so that the bottom one is cut off, but that there are not enough forms to actually scroll. I think just checking scrolling on the "Delete form" page (for Saved and Blank forms) is enough here.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review May 18, 2023 11:52
@dbemke
Copy link

dbemke commented May 19, 2023

Tested with Success!

Verified on device with Android 8.1, 10

Verified cases:

@srujner
Copy link

srujner commented May 19, 2023

Tested with Success!

Verified on device with Android 13

@grzesiek2010 grzesiek2010 merged commit d662851 into getodk:master May 19, 2023
6 checks passed
@seadowg seadowg deleted the delete-form-lists branch May 19, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of forms doesn't scroll in "Delete form"
4 participants