Fix list view heights for delete lists #5597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5594
What has been done to verify that this works as intended?
Verified manually.
Why is this the best possible solution? Were any other approaches considered?
No other option here - the height for the list views was incorrectly set to fill the whole screen (rather than the available space).
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
As I pointed out in the issue, this ended up being pretty hard to reproduce as you need the exact right number of forms so that the bottom one is cut off, but that there are not enough forms to actually scroll. I think just checking scrolling on the "Delete form" page (for Saved and Blank forms) is enough here.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.