Stop using WeakReference in BaseLocationClient #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
changed the title
seadowg
approved these changes
Jun 22, 2023
grzesiek2010
force-pushed
the
COLLECT-5208
branch
from
b7a3e4c
to
5efea9b
Compare
|
Something strange happened with maps. Mapbox is not available as a source of maps in settings and Google maps don't show the map (blank background, unable to zoom in/out) |
|
@dbemke are you using the build created by CI? I'm realising you'll need to manually build to test maps (other than OSM), as we don't include our Google Maps or Mapbox keys in the CI build (so neither will work). |
|
Yes, the CI build |
grzesiek2010
force-pushed
the
COLLECT-5208
branch
from
5efea9b
to
43a9f6d
Compare
grzesiek2010
force-pushed
the
COLLECT-5208
branch
from
43a9f6d
to
781f804
Compare
|
Tested with Success! Verified on device with Android 10 Verified cases:
|
|
Tested with Success! Verified on device with Android 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5208
What has been done to verify that this works as intended?
I've tested the changes manually.
Why is this the best possible solution? Were any other approaches considered?
The only interesting thing here is that after getting rid of using WeakReference I decided to combine setting listeners with start/stop methods see: d888d58 and 2246046 Those two were always called together so I thought that it made sense to combine them.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please test everything related to using GPS which means geo widgets and background location tracking. Please also test carefully if after recreating the activity/getting back to the app tracking location works correctly since this is the biggest area of risk I guess.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with geo widgets and background location tracking like the
All widgetsform and AuditTest.xml.txtDoes this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.