Dismiss snackbar before creating a new one #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
reviewed
Jul 18, 2023
| }.show() | ||
| }.addCallback(object : BaseTransientBottomBar.BaseCallback<Snackbar>() { | ||
| override fun onDismissed(transientBottomBar: Snackbar?, event: Int) { | ||
| super.onDismissed(transientBottomBar, event) |
There was a problem hiding this comment.
You might have already done this, but I think there's a couple of situations that we should double check that this gets called in:
- When the Snackbar is dismissed after being on screen for its duration
- When the Snackbar is dismissed manually
- When the Activity is destroyed before the Snackbar is dismissed
There was a problem hiding this comment.
I've checked those cases and it seems to work well.
seadowg
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5662
What has been done to verify that this works as intended?
I've reviewed implemented changes.
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue it seems to be an Android bug and hopefully, this change will help us.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.