Fixed button heights

[grzesiek2010]

Closes #5562

What has been done to verify that this works as intended?

I've tested the fix manually.

Why is this the best possible solution? Were any other approaches considered?

Both buttons have the same height and it's the height of the higher one.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

In the Main menu -> Delete Form we have two tabs. Both look similar and have two identical buttons Select all/Delete selected. Despite the fact that both layouts look so similar they are defined in two different places (including the buttons) so please verify the fix for both tabs.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[dbemke]

Select All button in Saved Forms changes heights after minimizing. It depends on the device but I think it’s possible to reproduce it on most of devices but with different settings. I managed to reproduce it on Android 8.1, 10, 11. Don’t keep activities might be enabled or disabled (it’s easier to reproduce with the setting enabled).
Szymon check also Android 12, 13. On Android 12 the issue doesn’t occur, on Android 13 the issue occurs in Select all/clear all in Saved Forms and Blank Forms.

Steps to reproduce:

1. In the device settings choose the biggest text size (or other setting that changes the size of buttons).
2. Enable don’t keep activities setting.
3. Go to Collect and send some forms.
4. Go to "Delete Form”.
5. Minimize the app and go to a different app.
6. Go back to Collect.

Before minimizing / After minimizing

[grzesiek2010]

This seems like a bug with ConstraintLayout + ListView I thought that maybe we should leave it as is but eventually fixed it using LineraLayout instead.

[srujner]

Tested with Success!

Verified on device with Android 12, 13

Verified cases:

• The issue The biggest text size in "Delete selected” button #5562 is no longer reproducing;
• Main Menu -> Delete Form -> Saved Forms/Blank Forms tabs;
• Different button size in Device Settings and in app settings;
• Different font size in Device Settings and in app settings;
• Don't keep activities setting enabled/disabled;
• Rotate the screen, minimize the app;
• Light and dark mode

[dbemke]

Tested with Success!

Verified on device with Android 8.1, 10, 11