New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain last-saved across form updates #5745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Oct 3, 2023
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDownloader.java
Outdated
Show resolved
Hide resolved
test-forms/src/main/resources/forms/one-question-last-saved-v1.xml
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-5557
branch
from
November 5, 2023 21:50
50bb4a7
to
6a239a9
Compare
seadowg
requested changes
Nov 6, 2023
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDownloader.java
Outdated
Show resolved
Hide resolved
...ect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDownloaderUseCases.kt
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-5557
branch
from
November 6, 2023 13:40
d6deb94
to
2e132f1
Compare
seadowg
approved these changes
Nov 6, 2023
Tested with Success! Verified on device with Android 10 Verified cases:
|
Tested with Success! Verified on device with Android 13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5557
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
Copying the
last-saved.xml
file while downloading a form update is the most obvious solution here since it's similar to what we do with media files that already exist and are also used by the updated version of the form.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Any form that uses https://docs.getodk.org/form-logic/#values-from-the-last-saved-record
I've used:
LastSavedTest.xlsx
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.