Add custom attribute to flag strings to review #5769
Conversation
| @@ -9,7 +9,7 @@ | |||
| the specific language governing permissions and limitations under the | |||
| License. | |||
| --> | |||
| <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingTranslation" tools:locale="en"> | |||
| <resources xmlns:tools="http://schemas.android.com/tools" xmlns:oat="http://schema.getodk.org/odkAndroidTools" tools:ignore="MissingTranslation" tools:locale="en"> | |||
There was a problem hiding this comment.
I wasn't sure about if we needed an actual like URL for this schema seeing as it's just an experiment for the moment. @lognaturel I think you have a bit more experience with XML schemas than me, so it would be interesting to see what your take is.
There was a problem hiding this comment.
It’s really just an opaque identifier so this looks great to me! Oats are tasty.
| @@ -216,10 +216,6 @@ android { | |||
| htmlReport true | |||
| lintConfig file("$rootDir/config/lint.xml") | |||
| xmlReport true | |||
|
|
|||
| if (!project.hasProperty("lintStrings")) { | |||
There was a problem hiding this comment.
This workflow makes it much easier to just add strings quickly in a PR (as copy becomes less of a concern) so I don't think we need this.
There was a problem hiding this comment.
Looks like a good experiment to me. @grzesiek2010 we’ll try out having placeholder strings during development and then finalizing them when all the functionality is complete. If we like this process we can decide what to do with Transifex if we use it when developing against master.
Add custom attribute to flag strings to review
Add custom attribute to flag strings to review
Add custom attribute to flag strings to review
This adds a new
toReviewattribute to strings that we want to review. The idea here is to allow copy discussions to happen separately from PR review: the strings can be reviewed later and then the flag can be removed when we're happy with them.We're going to experiment with this process on the
v2023.3.xand then decide if we want to continue it when merging everything back in tomaster.