Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate old finalize key correctly #5795

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 24, 2023

Closes #5788

Why is this the best possible solution? Were any other approaches considered?

The problem was just that older migrations were migration straight to the new "finalize in form entry" setting rather than to the old "finalize" (which would then have the newer migrations run on it).

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I've only made changes to settings migrations here, so focusing on that will be fine.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 24, 2023 12:03
@seadowg seadowg added the high priority Should be looked at before other PRs/issues label Oct 24, 2023
@dbemke
Copy link

dbemke commented Oct 25, 2023

We checked scanning a QR code form 2022.3.0 and upgrading from 2022.3.0 but the results are the same as in the screenshots in PR#5776. I thought that "Finalize all drafts" will be unchecked when in the old version "finalize all forms" was unchecked...so I guess there's something wrong or I followed wrong steps or thinking about different expected results. Could you describe the expected result in settings in old and new versions?

@dbemke
Copy link

dbemke commented Oct 25, 2023

Tested with Success!

Verified on device with Android 10, 13 (by Szymon)

Verified cases:

  • upgrading from 2022.3.0 with Default to finalized and Mark form as finalized disabled (Finalize all drafts is disabled in the new version)
  • adding a project via QR code from 2022.3.0 with Default to finalized and Mark form as finalized disabled

@seadowg seadowg merged commit 1f9b6c2 into getodk:v2023.3.x Oct 25, 2023
6 checks passed
@seadowg seadowg deleted the migrate-old-settings branch October 25, 2023 15:46
seadowg added a commit to seadowg/collect that referenced this pull request Oct 26, 2023
seadowg added a commit to seadowg/collect that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include "finalize all drafts" setting in migration of old "mark form as finalized"
3 participants