Fixed searching in the list of drafts #5797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm ok with the idea of backfilling when we rework this screen. |
seadowg
approved these changes
Oct 25, 2023
|
Tested with Success! Verified on device with Android 13 Verified cases:
|
|
Tested with Success! Verified on device with Android 10 |
seadowg
pushed a commit
to seadowg/collect
that referenced
this pull request
Oct 26, 2023
Fixed searching in the list of drafts
seadowg
pushed a commit
to seadowg/collect
that referenced
this pull request
Oct 30, 2023
Fixed searching in the list of drafts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5796
Why is this the best possible solution? Were any other approaches considered?
That method was already updated but only for the case with no search text see https://github.com/getodk/collect/compare/v2023.3.x...grzesiek2010:COLLECT-5796?expand=1#diff-37147e150adcca4396232ebf94609b5ef3b79226becb8b5686c740d78ab8bda5R49 so I did the same for searching.
I haven't added any tests because that method does not have any... generally the whole class does not have tests and is marked as deprecated so I'm torn when it comes to adding tests now or waiting for refactoring and then doing that. @seadowg if you think we definitely need to cover this change with tests I will do that.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Testing searching in the list of drafts should be enough. Nothing else should be affected.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.