Use recommended OSM tile URL #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports HTTP/2 and HTTP/3 so aliases are no longer required to support connection concurrency
|
🤔 But I imagine osmdroid doesn't take advantage of HTTP/2 features when downloading tiles? So maybe this will slow down tile loading? Even if that is the case, I don't think it would be significant. |
|
Marking this as a draft as some of the checklist isn't done. |
|
I had to think about implications a little more. I do think it's possible this will make downloads a bit slower but I doubt it would be meaningful if that's the case. osmdroid's examples have been updated similarly so I think it's the right move: https://github.com/osmdroid/osmdroid/blob/master/osmdroid-android/src/main/java/org/osmdroid/tileprovider/tilesource/TileSourceFactory.java#L100 I don't believe there are any meaningful tests to write for this. |
seadowg
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports HTTP/2 and HTTP/3 so aliases are no longer required to support connection concurrency
Why is this the best possible solution? Were any other approaches considered?
This is what openstreetmap/operations#737 recommends. I verified I could launch a map with OSM tiles.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Worst case is that OSM tiles stop working.
Do we need any specific form for testing your changes? If so, please attach one.
No. Can use the filled form map.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.