Updated messages displayed in empty lists

[grzesiek2010]

Closes #5820

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please review the messages displayed when the list of forms is empty:

• the list of blank forms
• the list of forms to download
• the list of forms to delete

other lists should be intact.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[grzesiek2010]

@alyblenkin please take a look.
Do you think that we should differentiate somehow messages displayed in the lists of forms to delete to have different ones for the list of blank forms and the list of filled forms? They exist in the same place and you switch between them just when you swipe left/right.

[alyblenkin]

The changes look good!

For blank forms we could say:
"No forms to delete: When you have downloaded blank forms they will appear here"

[grzesiek2010]

Maybe:
No forms to delete: Once you have downloaded blank forms they will appear here
Instead of:
No forms to delete: When you have downloaded blank forms they will appear here

to make it consistent with:
No forms to delete: Once you have saved forms they will appear here

hmm?

[alyblenkin]

@grzesiek2010 - I actually made that subtle change, so people noticed the difference. I thought about changing the icon to make it more obvious, but there isn't really a good option to represent the situation. That being said, I think both work fine! The difference between "when" and "once" is probably so small people wouldn't notice, so we can just make them consistent.

[grzesiek2010]

Ok let's use when and once. Please review.

[srujner]

@grzesiek2010 - I actually made that subtle change, so people noticed the difference. I thought about changing the icon to make it more obvious, but there isn't really a good option to represent the situation. That being said, I think both work fine! The difference between "when" and "once" is probably so small people wouldn't notice, so we can just make them consistent.

Actually it was the first thing I noticed and I wanted to give a comment about why there is "When' Instead of "Once", but then I read the comments above.

[srujner]

Tested with Success!

Verified on device with Android 13

Verified cases;

• The list of blank forms
• The list of forms to download
• The list of forms to delete
• Check on other list of forms;
• Light and Dark mode;
• Rotate the screen, minimize the app;
• Using Search;

[dbemke]

Tested with Success!

Verified on device with Android 10