Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB ANRs during form entry #5867

Merged
merged 30 commits into from
Jan 22, 2024
Merged

Fix DB ANRs during form entry #5867

merged 30 commits into from
Jan 22, 2024

Commits on Jan 17, 2024

  1. Remove UI thread writes to the DB

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    582591a View commit details
    Browse the repository at this point in the history

  2. Add slow call for accessing readable database

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3c03dbf View commit details
    Browse the repository at this point in the history

  3. Load BlankFormListItems off the UI thread

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    64be103 View commit details
    Browse the repository at this point in the history

  4. Use Flow instead of LiveData to run map on background thread

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    70a057e View commit details
    Browse the repository at this point in the history

  5. Convert TestScheduler to Kotlin

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f51a815 View commit details
    Browse the repository at this point in the history

  6. Support using Scheduler for Flows

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    781c04c View commit details
    Browse the repository at this point in the history

  7. Fix Form equality for StateFlow

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c506468 View commit details
    Browse the repository at this point in the history

  8. Add Flow support to FakeScheduler

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3eaf6e6 View commit details
    Browse the repository at this point in the history

  9. Fix test helper usage

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    16591fc View commit details
    Browse the repository at this point in the history

  10. Rename method

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    629e764 View commit details
    Browse the repository at this point in the history

  11. Assert form can be started on background thread

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b3743aa View commit details
    Browse the repository at this point in the history

  12. Move form path to constructor

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a82545 View commit details
    Browse the repository at this point in the history

  13. Use Uri as input for FormLoaderTask

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    50749f8 View commit details
    Browse the repository at this point in the history

  14. Ignore broken tests for now

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6631caf View commit details
    Browse the repository at this point in the history

  15. Allow loading form without StrictMode violation

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    11a0fdb View commit details
    Browse the repository at this point in the history

  16. Lock in current StrictMode coverage for forms db

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    95ed0a6 View commit details
    Browse the repository at this point in the history

  17. Lock in current StrictMode coverage for forms db

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b928e90 View commit details
    Browse the repository at this point in the history

  18. Rework FormLoaderTask tests 

    * Move select with CSV to feature level
* Remove tests for features covered by other tests
* Delete FormNavigationTest as it feels like our feature tests
now cover navigation pretty well
    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e84d3fa View commit details
    Browse the repository at this point in the history

  19. Update and reenable remaining FormLoaderTask tests

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    87b77f0 View commit details
    Browse the repository at this point in the history

  20. Add loading state to FormUriActivity

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    aa69ee8 View commit details
    Browse the repository at this point in the history

  21. Remove new Form and Instance fields

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3ca0a73 View commit details
    Browse the repository at this point in the history

  22. Remove unused field

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    859f0c4 View commit details
    Browse the repository at this point in the history

  23. Move change language logic to view model

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    aaa54b7 View commit details
    Browse the repository at this point in the history

  24. Remove unneeded variable

    @seadowg
    seadowg committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d314f45 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Fix param names

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bdef028 View commit details
    Browse the repository at this point in the history

  2. Correct test description

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    eee3ec4 View commit details
    Browse the repository at this point in the history

  3. Simplify ExternalSecondaryInstanceTest

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4f74596 View commit details
    Browse the repository at this point in the history

  4. Fix case where form has been deleted

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8d537ae View commit details
    Browse the repository at this point in the history

  5. Simplify boolean logic

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c60752e View commit details
    Browse the repository at this point in the history

  6. Fix deleted form logic

    @seadowg
    seadowg committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f5fd65c View commit details
    Browse the repository at this point in the history