-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log current screen after saving a form #5918
Conversation
|
||
assertThat(auditLog[2].get("event"), equalTo("form save")) | ||
|
||
assertThat(auditLog[3].get("event"), equalTo("question")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an assertion on the question paths here (and in the other question
events)? I think that'll help readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Tested with Success! Verified on device with Android 10 Verified cases:
|
Tested with Success! Verified on device with Android 13 |
Closes #5915
Why is this the best possible solution? Were any other approaches considered?
Logging the current screen was removed in this pr: #5839 so to fix the issue I've just brought it back.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should just solve the issue. I don't think it's risky since the fix brings back the code that already existed in v2023.3.1 and older versions but it's not the first issue with audits we have discovered recently so there might be more.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass