Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icon colors used in AudioVideoImageTextLabel #6056

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 28, 2024

Closes #6048

Why is this the best possible solution? Were any other approaches considered?

The problem was that we tried to set the color of the audio button programmatically using colorOnSurface. It was a wrong color obviously but it looks like we don't need to set it at all. It works well as the audio button uses the proper style.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This can only affect the way the audio button looks like. Please make sure it has the proper color no matter if the audio is playing or not.

Do we need any specific form for testing your changes? If so, please attach one.

The form attached to the issue is ok.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg merged commit b672483 into getodk:master Apr 2, 2024
6 checks passed
@WKobus
Copy link

WKobus commented Apr 3, 2024

Tested with success!
Verified on devices with Androids: 11
Verified cases:

@srujner
Copy link

srujner commented Apr 3, 2024

Tested with success!

Verified on devices with Androids: 10,13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio icon button- wrong color of the speaker
4 participants