Fixed icon colors used in AudioVideoImageTextLabel #6056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6048
Why is this the best possible solution? Were any other approaches considered?
The problem was that we tried to set the color of the audio button programmatically using
colorOnSurface
. It was a wrong color obviously but it looks like we don't need to set it at all. It works well as the audio button uses the proper style.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This can only affect the way the audio button looks like. Please make sure it has the proper color no matter if the audio is playing or not.
Do we need any specific form for testing your changes? If so, please attach one.
The form attached to the issue is ok.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass