Fix pdf links #1420
Merged
Fix pdf links #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Jan 11, 2022
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM python:3 | |||
| FROM python:3.9.7 | |||
There was a problem hiding this comment.
Thanks for separating out changes into little pull requests! Now that the version change has been merged, you can git rebase upstream/master and then git push --force and this commit should no longer be visible here.
lognaturel
reviewed
Jan 11, 2022
| @@ -11,7 +11,7 @@ | |||
| {% endif %} | |||
|
|
|||
| <hr/> | |||
| <p class="footerText"><a href="_downloads/ODK-Documentation.pdf" download>Download this documentation as a PDF.</a></p> | |||
| <p class="footerText"><a href="https://docs.getodk.org/_downloads/ODK-Documentation.pdf" download>Download this documentation as a PDF.</a></p> | |||
There was a problem hiding this comment.
This works for the published version! But it will give a false sense of the world with a set of docs hosted somewhere else or locally. Ideally this could dynamically use the base url.
jennifermklein
force-pushed
the
fix-pdf-links
branch
from
6db6a4f
to
776dfcd
Compare
|
I think it's better we flip things around here. That is, merge the fix and file an issue to reduce the use of absolute paths. I'll do that now.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1417
What is included in this PR?
I noticed that the link on the Contributing to ODK Docs page to Download this documentation as a PDF did not work and would yield a "Failed - No file" message in the download bar. I updated the link in the footer.html file to include the entire link an incorrect path isn't inadvertently used.
What is left to be done in the addressed issue?
Confirm correct link is being used and correct document is being accessed.