Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Class added to style generic admonition like note. #157

Closed
wants to merge 1 commit into from
Closed

[WIP] Class added to style generic admonition like note. #157

wants to merge 1 commit into from

Conversation

troublemagnet
Copy link
Contributor

A new class called genericstyle has been added for styling generic admonitions. The styling is same as the styling for note. Please find the screenshots attached which show how an admonition looks like and how we can override the default styling.
black
heyy

Closes #98.

@troublemagnet
Copy link
Contributor Author

@adammichaelwood This issue sphinx-doc/sphinx#3754 has the description of why the build fails. Turns out that switching to sphinx 1.5.6 is the solution.

@adammichaelwood
Copy link
Contributor

The CSS work is great.

But this is the wrong approach for adding new styles. We don't need a new CSS file, which means we don't need to update conf.py or header.html

The new style class should be appended to the existing _static/css/custom.css (with a code comment explaining what it is, what it does, and referencing the issue number). No other changes should be required or included in this PR.

@adammichaelwood
Copy link
Contributor

Also:

Is there a way to style the admonition without forcing the user to add a class to the markup? Are there any admonition-specific classes already present in the html output which can be used?

@troublemagnet
Copy link
Contributor Author

@adammichaelwood I shall research more and will try to find out an alternative way to do it. Also I'll move it to custom.css.

@adammichaelwood
Copy link
Contributor

Just look at the output in your browser dev tools. There's got to be something already there to hang the styles on.

@adammichaelwood
Copy link
Contributor

Are you going to complete this PR?

@troublemagnet troublemagnet changed the title Class added to style generic admonition like note. [WIP] Class added to style generic admonition like note. Sep 15, 2017
@troublemagnet
Copy link
Contributor Author

@adammichaelwood yes sir, I'm on it.

@troublemagnet
Copy link
Contributor Author

I'll fix this locally and make a new PR ASAP.

wbrunette added a commit to wbrunette/docs that referenced this pull request Oct 26, 2021
Update ODK-X documentation to show current minimum Android version as Version 5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants