Replace install local script with Gradle task #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
install-local
branch
2 times, most recently
from
84c5b6f
to
9a0b562
Compare
seadowg
force-pushed
the
install-local
branch
from
9a0b562
to
7963c56
Compare
seadowg
commented
Feb 9, 2022
| @@ -66,12 +66,33 @@ jar { | |||
| } | |||
| } | |||
|
|
|||
| // Useful for testing | |||
| task explodedJar(type: Copy) { | |||
There was a problem hiding this comment.
I don't think we need this now we have installLocal.
lognaturel
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
Had some spare time near the end of the day so took care of this.
What has been done to verify that this works as intended?
Tried locally.
Why is this the best possible solution? Were any other approaches considered?
Discussed in the issue.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No change to users just provides a helper script for development.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
This will need followed up with a change to the Collect README.