Add tests for geojson integer ids #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
Apr 28, 2022
| assertThat(featureCollection.getChildAt(0).getNumChildren(), is(4)); | ||
| assertThat(featureCollection.getChildAt(0).getChild("id", 0).getValue().getValue(), is("77")); | ||
|
|
||
| assertThat(featureCollection.getChildAt(1).getChild("id", 0).getValue().getValue(), is("78")); |
There was a problem hiding this comment.
Unless I'm missing something, there is no reason to have more than one feature in the JSON to check that integer IDs get parsed correctly.
There was a problem hiding this comment.
This is not my best habit. While I like targeted tests, I'm also very paranoid about the 1-element case being special. You're right that it's really not necessary here and I've removed it.
seadowg
approved these changes
Nov 23, 2022
lognaturel
force-pushed
the
integer-ids
branch
from
2b27f3b
to
28f0e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #666 馃槇
A few additional test cases to verify that integer ids are supported. I also verified in Collect and didn't see any problems.