Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespaced TreeElements #696

Closed
wants to merge 4 commits into from
Closed

Fix namespaced TreeElements #696

wants to merge 4 commits into from

Commits on Oct 26, 2022

  1. Consider namespace when comparing node names

    @lognaturel
    lognaturel committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    8a44276 View commit details
    Browse the repository at this point in the history

  2. Serialize and deserialize namespace prefix 

    An alternative would be to serialize the namespace map. Currently this is only available at parse time so it would be a bigger change. We generally don't expect many namespaced instance elements so this is a pragmatic approach for now. If we find namespace usage takes off, we can reconsider.
    @lognaturel
    lognaturel committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6ab1370 View commit details
    Browse the repository at this point in the history

  3. Fix getAttribute with namespaced attributes 

    There was a test for this but the assertion was wrong. Fixed that and added more cases. Ideally the attribute namespace would never be a blank string but I can't figure out where that is being set.
    @lognaturel
    lognaturel committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9c7109b View commit details
    Browse the repository at this point in the history

  4. Save attribute namespace prefixes

    @lognaturel
    lognaturel committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c1cd379 View commit details
    Browse the repository at this point in the history