Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty string if child has no value #705

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

lognaturel
Copy link
Member

Closes #703

What has been done to verify that this works as intended?

New test

Why is this the best possible solution? Were any other approaches considered?

Can't think of an alternative.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Can't think of any risk!

Do we need any specific form for testing your changes? If so, please attach one.

See test.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

@seadowg seadowg merged commit ff578d4 into getodk:master Jan 9, 2023
@lognaturel lognaturel deleted the getEmptyChild branch January 9, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app crashes in select place if in xml file there is a blank space in geometry values
2 participants