Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Commons IO to prevent Android compatibility issues #716

Merged
merged 1 commit into from
May 15, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented May 15, 2023

Closes getodk/collect#5579

What has been done to verify that this works as intended?

Verified manually.

Why is this the best possible solution? Were any other approaches considered?

Not a lot else to do here - the only alternative would be to make JavaRosa (and therefore Collect) only compatible with API 26+.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I don't think there's much risk here. It is a bit scary downgrading as we are most likely bringing in bugs (from commons-io), but all tests are green (here and in Collect using this), so we're hopefully fine.

@seadowg
Copy link
Member Author

seadowg commented May 15, 2023

@getodk/testers do we test with a device with Android 7.1.1 or lower as part of regression? Just want to check whether this is a gap in our testing or not.

@seadowg seadowg marked this pull request as ready for review May 15, 2023 13:35
@srujner
Copy link

srujner commented May 15, 2023

@seadowg We used to have a single steps for a 5.1 in some test cases ~10, but we stopped checking it as we're mainly focusing on Android 10 and 13 and we have 8.1 for PRs

@lognaturel lognaturel merged commit 4297022 into getodk:master May 15, 2023
3 checks passed
@seadowg seadowg deleted the commons-io branch May 15, 2023 14:04
@lognaturel
Copy link
Member

lognaturel commented May 15, 2023

The Android version checker is supposed to help us with things like this but it doesn’t because it’s a runtime exception!

I don’t think we need to change our process. I’ll continue using older devices and if we don’t catch these kinds of problems before releasing we’ll see them in logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on form download
3 participants