Fix custom function handler support #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
fix-custom-funcs
branch
from
33a6941
to
28e3718
Compare
lognaturel
approved these changes
Aug 29, 2023
| public static FormDef createFormDef(String formName, XFormsElement form) throws IOException, XFormParser.ParseException { | ||
| Path formFile = createTempDirectory("javarosa").resolve(formName + ".xml"); | ||
| String xml = form.asXml(); | ||
| System.out.println(xml); |
There was a problem hiding this comment.
We should probably clean these up at some point (it's also in the source init implementation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been broken by #722.
What has been done to verify that this works as intended?
New and existing tests.
Why is this the best possible solution? Were any other approaches considered?
I'd really like to deprecate
FormDef#getEvaluationContextas it really doesn't feel like it belongs there. I might do an afternoon spike on that and see how far I can get, but it's definitely too much work to hold up a fix for.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This basically reverts the behavior to how it was pre #722 so this is hopefully fairly low risk. That said, changes to this are are pretty scary and can have subtle side effects.